Conversation
RobertJoonas
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when running E2E tests without internet connection, each
page.gotocall takes several seconds, close to 10. This in turn makes basically all tests fail. WithwaitUntiloption set tocommit, we wait only until the page HTML starts loading. The default option value isload, which waits until all resources load. In practice however, given the tests are written according to guidelines (using playwright actions likeclick(), checking for visibility of expected elements withtoBeVisible()etc.), we do not have to wait until the page's resources are fully loaded. The most likely reason for the slowdown are attempts to load gravatar images, which eventually time out.After the change, the tests complete when offline, although they are still noticeably slower (~23 seconds vs ~38 seconds). Yet still, being able to run them offline at all is still in improvement.
Another benefit is that with the option added, even when the tests are run online, they execute faster (~18 seconds vs ~23 seconds).
Refs https://www.checklyhq.com/blog/why-page-goto-is-slowing-down-your-playwright-test/
Changes
Please describe the changes made in the pull request here.
Below you'll find a checklist. For each item on the list, check one option and delete the other.
Tests